-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/teuthology_api/suite: Modify how we handle Error and Success runs #51
base: main
Are you sure you want to change the base?
Conversation
b26134e
to
79f5529
Compare
bd56531
to
9f0b855
Compare
The changes includes: 1. make suite route return {"run": run_details, "logs": logs, "job_count": job_count} 2. Improve how we handle Exception by utilizing Queue from python multiprocessing library. 3. Set the timeout for the process to be 180 seconds, if teuthology doesn't respond back within that time, then we return a Process Timeout Signed-off-by: Kamoltat Sirivadhna <[email protected]>
9f0b855
to
4cb256a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
.gitignore
Outdated
@@ -53,3 +53,6 @@ MANIFEST | |||
.conda*/ | |||
.python-version | |||
venv | |||
|
|||
#.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can maybe remove this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed with the new commit!
Signed-off-by: Kamoltat Sirivadhna <[email protected]>
Added job counts to unittest. Signed-off-by: Kamoltat Sirivadhna <[email protected]>
8d07315
to
8df1c86
Compare
Integration test failed because of the python version issue, awaiting for |
As per As per: ceph/pulpito-ng#23
The changes includes:
make suite route return
{"run": run_details, "logs": logs, "job_count": job_count}
Improve how we handle Exception by utilizing Queue from
python multiprocessing library.
Set the timeout for the process to be 180 seconds, if teuthology
doesn't respond back within that time, then we return a Process Timeout
Add .env to gitignore
Contribution Guidelines
To sign and test your commits, please refer to Contibution guidelines.
Checklist